Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idle-crafting: make choice of crafting job dependent on linked stockpiles. #1300

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

chdoc
Copy link
Member

@chdoc chdoc commented Sep 11, 2024

No description provided.

@chdoc chdoc changed the title idle-crafting: make choice of crafting job dependent on inked stockpiles. idle-crafting: make choice of crafting job dependent on linked stockpiles. Sep 11, 2024
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

changelog.txt Outdated Show resolved Hide resolved
docs/idle-crafting.rst Outdated Show resolved Hide resolved
local function for_inputs(workshop, action)
if #workshop.profile.links.take_from_pile == 0 then
dfhack.error('workshop has no links')
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can turn the else into an end and save some indentation in the rest of the function. dfhack.error throws and does not allow the function to continue.

idle-crafting.lua Outdated Show resolved Hide resolved
idle-crafting.lua Outdated Show resolved Hide resolved
changelog.txt Outdated Show resolved Hide resolved
idle-crafting.lua Outdated Show resolved Hide resolved
idle-crafting.lua Outdated Show resolved Hide resolved
@myk002 myk002 merged commit e8fd606 into DFHack:master Sep 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants