Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it much harder to accidentally offend the elves #1264

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Aug 12, 2024

  • DFHack dialogs for trade screens (both Bring goods to depot and the Trade barter screen) can now filter by item origins (foreign vs. fort-made) and can filter bins by whether they have a mix of ethically acceptable and unacceptable items in them
  • If you have managed to select an item that is ethically unacceptable to the merchant, an "Ethics warning" badge will now appear next to the "Trade" button. Clicking on the badge will show you which items that you have selected are problematic. The dialog has a button that you can click to deselect the problematic items in the trade list.
  • If you have ethically unacceptable items selected for trade, the "Are you sure you want to trade" confirmation will warn you about them
  • Layout overhaul for both trade dialogs

Fixes: DFHack/dfhack#4836

@myk002
Copy link
Member Author

myk002 commented Aug 12, 2024

vidcap-2024-08-12_09.12.55.mp4

@myk002 myk002 merged commit afef23f into DFHack:master Aug 12, 2024
10 checks passed
@myk002 myk002 deleted the myk_traaaaade branch August 12, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

show warning when unethical items come along for the ride when selecting bins in the bring goods UI
1 participant