Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embark Anyone #1260

Merged
merged 12 commits into from
Aug 9, 2024
Merged

Embark Anyone #1260

merged 12 commits into from
Aug 9, 2024

Conversation

ProtonNumber
Copy link
Contributor

Allows you to embark as any civilization, including dead and non-dwarven ones through a unretire-anyone style UI.

Currently suffers from some issues with counting sites, especially with non-dwarven civs. This is ultimately a cosmetic issue, but I'd be interested if anyone has a more accurate method of doing this.

docs/embark-anyone.rst Outdated Show resolved Hide resolved
docs/embark-anyone.rst Outdated Show resolved Hide resolved
docs/embark-anyone.rst Outdated Show resolved Hide resolved
docs/embark-anyone.rst Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
docs/embark-anyone.rst Outdated Show resolved Hide resolved
docs/embark-anyone.rst Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
embark-anyone.lua Outdated Show resolved Hide resolved
@myk002
Copy link
Member

myk002 commented Aug 9, 2024

At your convenience, please also add your name to https://github.com/DFHack/dfhack/blob/develop/docs/about/Authors.rst

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! there's one last thing I forgot to mention: could you add a line under the "New tools" header in the "Future" version in changelog.txt?

https://github.com/DFHack/scripts/blob/master/changelog.txt#L30

@myk002 myk002 merged commit c049953 into DFHack:master Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants