Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui/journal improvements #1237

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

wiktor-obrebski
Copy link
Contributor

Introduce:

  • keep journal size and position between sessions
  • add help button to the gui journal
  • add some pen caching and scrolling tests
  • refactor journal into logic submodules

@myk002
Copy link
Member

myk002 commented Jul 18, 2024

looks like test failures (and missing EOL)

In ASCII mode Help button seems to take more tiles/have one tile
smaller offset that in graphical mode. This is source of issues with tests
on ASCII mode
@wiktor-obrebski wiktor-obrebski force-pushed the gui/journal-improvements branch from 94d238a to 81a8258 Compare July 20, 2024 20:40
@myk002 myk002 merged commit 2f21498 into DFHack:master Jul 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants