-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Exterminate #1187
Merged
Merged
Update Exterminate #1187
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
27ea49d
Fix exterminate crashing in adventure mode when used with "disintegra…
Crystalwarrior 7c87abb
Remove the --maximum option, that's a feature not a bug fix
Crystalwarrior c7ce259
Don't think I need to recursively delete contents with dfhack.items.r…
Crystalwarrior 67e6f39
Teleport DISINTEGRATED units to the top of the world (maybe teleport …
Crystalwarrior 4e06ed8
Add KNOCKOUT method
Crystalwarrior cd4da57
expand exterminate changelog
Crystalwarrior 517d777
Merge branch 'master' into exterminate-update
myk002 08b1a0d
fix merge error
myk002 2c75517
Add the ability to "traumatize" units, which should force them in a s…
Crystalwarrior 09c3b7d
Update changelog.txt
myk002 15a70fb
Update changelog.txt
myk002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does isOwnGroup behave in adventure mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't. isOwnGroup only checks plotinfo which is irrelevant to adventure mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that mean it always returns false, or that it returns garbage data?