-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bodyswap to work on the latest adv-beta #1136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also needs a line in the changelog. New Tools, "reinstated" format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs "reinstated" changelog entry
As rome of oxtrot mentioned on Discord, please also add your name to Authors.rst |
Co-authored-by: Myk <[email protected]>
code looks reasonable, but from Discord I'm gathering there are still open questions about the behavior of this script, is that right? btw still needs |
Fix create_nemesis using bools instead of ints as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs changelog entry
Since this fixes the functionality the script came with originally, step 2 is making the script not auto add to core party and resolve any retire issues on adventurers that become wanderers post body swap and look into how the game handles those units |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create an issue on GitHub detailing the surrounding issues you've found with the script's behavior? I want to make sure they're recorded so we don't forget about them.
Also adds automatic re-centering on the unit you bodyswapped to!