Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bodyswap to work on the latest adv-beta #1136

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

Crystalwarrior
Copy link
Contributor

Also adds automatic re-centering on the unit you bodyswapped to!

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs a line in the changelog. New Tools, "reinstated" format.

bodyswap.lua Outdated Show resolved Hide resolved
bodyswap.lua Outdated Show resolved Hide resolved
bodyswap.lua Show resolved Hide resolved
@Crystalwarrior Crystalwarrior requested a review from myk002 June 2, 2024 01:57
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs "reinstated" changelog entry

bodyswap.lua Outdated Show resolved Hide resolved
bodyswap.lua Outdated Show resolved Hide resolved
@myk002
Copy link
Member

myk002 commented Jun 2, 2024

As rome of oxtrot mentioned on Discord, please also add your name to Authors.rst

@myk002
Copy link
Member

myk002 commented Jun 2, 2024

code looks reasonable, but from Discord I'm gathering there are still open questions about the behavior of this script, is that right?

btw still needs changelog.txt entry

Fix create_nemesis using bools instead of ints as expected
bodyswap.lua Show resolved Hide resolved
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changelog entry

@Crystalwarrior
Copy link
Contributor Author

Since this fixes the functionality the script came with originally, step 2 is making the script not auto add to core party and resolve any retire issues on adventurers that become wanderers post body swap and look into how the game handles those units

@Crystalwarrior Crystalwarrior requested a review from myk002 June 7, 2024 21:37
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create an issue on GitHub detailing the surrounding issues you've found with the script's behavior? I want to make sure they're recorded so we don't forget about them.

@myk002 myk002 merged commit fb69e01 into DFHack:master Jun 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants