Advfort2 #931
Merged
Advfort2 #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit [fallback] option to the workshop jobs when sometimes the hacky way fails. Fix brewing accepting too many items instead of barrel. Fix tallow making reaction. Add a limited display of item filters when adding items in a job slot.
| @@ -126,19 +126,6 @@ jobs_workshop={ | |||
| job_fields={job_type=df.job_type.CatchLiveFish} | |||
| }, -- no items? | |||
| }, | |||
| [df.workshop_type.Still]={ | |||
There was a problem hiding this comment.
Does workshop_type need to be updated?
There was a problem hiding this comment.
Nope this file (workshops.lua) is out of date. Though not much depends on it but there are some jobs that are no longer hardcoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes to advfort. There also a bug with workshops.lua that it's outdated. E.g. still is no longer a hardcoded building. Somebody should look the full list other :P