-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dfusion, df2mc, mapexport, dwarfexport #751
Conversation
It's been four years since meaningful updates, and in that time alternatives have emerged to almost everything. Any remaining functionality to replace is on the issue tracker. Simpler is better, for users and developers, and removing a legacy system makes it easier to understand how DFHack works.
It's still got it's own repo, but it hasn't been compatible with Minecraft for years and shouldn't be in the DFHack repo.
It's been disabled for more than a year, and nobody misses it. If that changes, it'll still be in the git history!
The Runesmith utility has long been replaced by Dwarf Therapist, and it's attribute-editing functions are very well supported directly by DFHack.
Doesn't dfusion control the |
No, that's |
mapexport is used for fortress overseer, but I don't know if anybody still On Tue, Dec 29, 2015 at 4:45 AM Lethosor [email protected] wrote:
|
Right now, I'm leaning towards removing df2mc and dfusion (waiting to hear back from @warmist on the latter). dwarfexport and mapexport might still be useful, at least until everything they implement is also implemented by RemoteFortressReader (which @JapaMala would know better than I would), so I'm leaning towards repairing them if that's possible. |
Just to have same info here as in irc. Dfusion is mostly outdated. Most important thing that i could think of is the site creation that should probably be moved to mod-tools. |
Remove dfusion, df2mc, mapexport, dwarfexport
Okay, so it turns out that the NEWS.rst entries here and in #754 wound up in the wrong section because the commits were made before 0.40.24-r5. Sorry about that. |
I don't know anything about dwarfexport, but mapexport is used by Fortress Overseer, which can't use anything else. But since the overseer project is abandoned, as far as I can see, we might be able to get rid of it unless somebody feels like updating it. |
(Pull already merged, but here's some rationale again) fortress overseer hasn't worked since 34.11 - it can't handle eg multitile trees - and was last updated in 2012. Plus the plugin hasn't compiled for ages.
|
Remove dfusion, df2mc, mapexport, dwarfexport
See #735 - these plugins have not been built since 40.01 (or earlier), and nobody missed them. DFusion has been built, but @warmist notes that almost all functions have been implemented by more recent tools (and multirace embarks is on the issue tracker).
This is mostly cleaning out unused code, with a side of making the project structure easier to understand for users and developers.
Only dfusion is noted as removed in NEWS.rst, as the others have already been removed from the release packages.