Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up moisture in Screen.cpp #5158

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Dec 30, 2024

Replace seven essentially identical functions with a template and seven instantiations of that template. Don't Repeat Yourself

Replace seven essentially identical functions with a template and seven instantiations of that template. Don't Repeat Yourself
Copy link
Member

@lethosor lethosor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, haven't tested

library/modules/Screen.cpp Outdated Show resolved Hide resolved
@myk002 myk002 merged commit b9e36c4 into DFHack:develop Dec 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants