Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stockpiles.lua to add functionality to import/export that was a work in progress before modification. #5000

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

unboundlopez
Copy link
Contributor

@unboundlopez unboundlopez commented Oct 13, 2024

Added functionality to import export on the stockpile menu.

Fixes: #4999

Added functionality to import export on the stockpile menu.
@unboundlopez
Copy link
Contributor Author

pre-commit.ci autofix

@unboundlopez
Copy link
Contributor Author

Dwarf.Fortress.2024.10.13-12.24.mp4

@chdoc
Copy link
Member

chdoc commented Oct 13, 2024

@myk002 Could you provide some context on 856237c (Part of #3285)

It looks to me like the functionality provided by this PR was already partially implemented, but commented out, beforehand.

@ab9rf
Copy link
Member

ab9rf commented Oct 31, 2024

Please give this PR a more descriptive name than "update stockpiles.lua". We often depend on being able to review code history to understand why code is the way it is, and commits and PRs with nondescript titles and descriptions are not helpful to this end.

@unboundlopez unboundlopez changed the title Update stockpiles.lua Update stockpiles.lua to add functionality to import/export that was a work in progress before modification. Oct 31, 2024
@unboundlopez
Copy link
Contributor Author

Updated the title.

@myk002
Copy link
Member

myk002 commented Dec 26, 2024

@myk002 Could you provide some context on 856237c (Part of #3285)

It looks to me like the functionality provided by this PR was already partially implemented, but commented out, beforehand.

Yeah, I got scared off from designing a UI that would make generated material filters and property filters intuitive. The stockpiles API is quite intimidating (and I say that even though I'm the one who wrote it). I was also completely burned out on stockpiles after the massive effort that went into updating the stockpiles plugin code so it could act as a backend for quickfort stockpile config scripting: https://docs.dfhack.org/en/stable/docs/guides/quickfort-user-guide.html#stockpile-configuration.

However, a simple approach like what this PR implements would at least be useful for copy/pasting stockpiles within a single fort, which is still a worthy use case.

@myk002 myk002 merged commit cbaca52 into DFHack:develop Dec 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Suggestion: Stockpile GUI Import/Export similar to work orders
4 participants