Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add small letters and on-off textures in top-left corners of 32x32 tiles #4144

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

TymurGubayev
Copy link
Contributor

These will be used in the gui/biomes script (DFHack/scripts#637)

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest names with no spaces in them to match with existing filenames. it also looks like we prefer dashes to underscores

@TymurGubayev
Copy link
Contributor Author

is on-off-top-left.png ok? It looks like 4 things now... Maybe something like on-off--top-left.png?

@myk002
Copy link
Member

myk002 commented Jan 6, 2024

is on-off-top-left.png ok? It looks like 4 things now... Maybe something like on-off--top-left.png?

a combination of dashes and underscores might be appropriate here -- on-off_top-left.png -- or maybe distinguish it by its tile size: on-off_map.png

@TymurGubayev
Copy link
Contributor Author

renamed with underscores (on the off chance we want bottom-right etc versions later)

@myk002 myk002 merged commit ccbefbe into DFHack:develop Jan 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants