Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted buildingplan filter reset hotkey to ctrl-d 'delete' #4030

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Adjusted buildingplan filter reset hotkey to ctrl-d 'delete' #4030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Template for new versions:
- `caravan`: price of vermin swarms correctly adjusted down. a stack of 10000 bees is worth 10, not 10000
- `sort`: when filtering out already-established temples in the location assignment screen, also filter out the "No specific deity" option if a non-denominational temple has already been established
- RemoteServer: continue to accept connections as long as the listening socket is valid instead of closing the socket after the first disconnect
- `buildingplan`: edit filter interface now uses ctrl-x to reset the filter to avoid conflict with increasing the filter's minimum quality (shift-x)
- `buildingplan`: overlay and filter editor gui now uses ctrl-d to delete the filter to avoid conflict with increasing the filter's minimum quality (shift-x)

## Misc Improvements
- `buildingplan`: display how many items are available on the planner panel
Expand Down
4 changes: 2 additions & 2 deletions plugins/lua/buildingplan/filterselection.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,9 @@ function QualityAndMaterialsPage:init()
},
widgets.HotkeyLabel{
frame={l=30, t=2},
label='Reset filter',
label='Delete filter',
auto_width=true,
key='CUSTOM_CTRL_X',
key='CUSTOM_CTRL_D',
on_activate=self:callback('clear_filter'),
},
},
Expand Down
4 changes: 2 additions & 2 deletions plugins/lua/buildingplan/planneroverlay.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,8 @@ function PlannerOverlay:init()
},
widgets.HotkeyLabel{
frame={b=0, l=1, w=22},
key='CUSTOM_X',
label='Clear filter',
key='CUSTOM_CTRL_D',
label='Delete filter',
on_activate=function() self:clear_filter(self.selected) end,
enabled=function()
return buildingplan.hasFilter(uibs.building_type, uibs.building_subtype, uibs.custom_type, self.selected - 1)
Expand Down