Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search to remaining Places pages #4019

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add search to remaining Places pages #4019

merged 3 commits into from
Nov 14, 2023

Conversation

ToxicBananaParty
Copy link
Contributor

No description provided.

myk002
myk002 reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure the Places sort additions are represented in docs/changelog.txt!

@ToxicBananaParty
Copy link
Contributor Author

Will do. I also need to add searching by assigned unit to workshops first.

myk002
myk002 reviewed Nov 14, 2023
View reviewed changes
plugins/lua/sort/places.lua Outdated Show resolved Hide resolved
plugins/lua/sort/places.lua Show resolved Hide resolved
@myk002 myk002 merged commit f081bda into DFHack:develop Nov 14, 2023
12 checks passed
@ToxicBananaParty ToxicBananaParty deleted the placesort branch November 14, 2023 07:53
myk002 added a commit that referenced this pull request Nov 14, 2023
@myk002
remove uneeded copypasta
bf19b63 
ref: #4019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myk002 myk002 myk002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
50.11-r3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToxicBananaParty @myk002