centralize management of mouse state #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethosor
reviewed
Oct 2, 2023
Comment on lines
+967
to
+968
| enabler->mouse_lbut = 0; | ||
| enabler->mouse_rbut = 0; |
There was a problem hiding this comment.
Should this also handle mbut? or the _down fields?
There was a problem hiding this comment.
We don't touch mbut in general so that map scrolling continues to work. The _down fields should not be modified since it can break dragging. Widgets capture the mouse on button click and then react to _down if they handled the click. if we mess with _down, then we can break whatever thinks the mouse belongs to them (including our own window dragging mechanism).
Co-authored-by: Alan <[email protected]>
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @lethosor for bringing this up. so much hackery could be removed.