Remove plugins - all broken since 0.40 #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes nothing at all as far as any DFHack user is concerned, as these plugins have not been possible to build since DF 34.11 - and would have to be rewritten for compatiblity with new native-DF systems. "treefarm" is additionally replaced by "autochop". In the unlikely event that a developer wants the source code for something... that's what version control is for!
|
I'm fine with removing treefarm since it has a successor. Not sure about the others, since they're not obsolete or impossible to fix. I'll look into them and see what the issues are. |
lethosor
changed the title
|
I looked into misery/advtools briefly and fixed a few issues, although they still don't work yet. I believe there are just a couple advtools subcommands that are obsolete and failing to compile, so I'll see if the rest work once those subcommands are removed. As for misery, I think the only thing needing to be changed is how bad thoughts/stress are generated. Anyway, I've removed treefarm, and I'll create issues to track the other two. |
lethosor
added a commit
that referenced
this pull request
Dec 9, 2016
Merge remote-tracking branch 'PeridexisErrant/remove-broken-plugins' advtools and misery are still partially broken, but parts of them still work, so repairing them is possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes nothing at all as far as any DFHack user is concerned, as these plugins have not been possible to build since DF 34.11 - and would have to be rewritten for compatiblity with new native-DF systems. "treefarm" is additionally replaced by "autochop".
In the unlikely event that a developer wants the source code for something... that's what version control is for!
This pull is inspired by #735.