MSVC: Fix generation of clsocket.lib #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Palakis
changed the title
|
Should exporting be optional? |
|
That's a good point. This might actually break DFHack because it uses a static library - I haven't checked yet. I've been too busy to work on this recently, but it could probably be addressed along with #19. |
|
@hayguen's fix in 9cbb2e7 should address the above. (It turns out that this PR didn't break DFHack, at least the build, according to CI run on DFHack/dfhack#1642 - not entirely sure if it'll break at runtime, though, and this is certainly worth fixing for other clients.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the library on Windows with the Visual Studio compiler,
clsocket.dllis generated correctly butclsocket.lib(the Import Library for use by programs linking with it) isn't generated at all because nothing is exported from the library.This PR fixes this by adding an
__declspec(dllexport)clause to the library's classes. This clause is abstracted behind anEXPORTconditional define, so that different platforms can use different export behaviors.