Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: fix typo in vendor sha #232

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Dec 13, 2024

image

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake checks worked locally, lgtm

@cafkafk cafkafk merged commit f4b7ecc into DBCDK:master Dec 13, 2024
10 checks passed
@johanot
Copy link
Contributor Author

johanot commented Dec 13, 2024

@cafkafk Thanks.

The CI never caught this typo, because the CI uses this package def: https://github.com/DBCDK/morph/blob/master/flake.nix#L79-L110

Should we remove one of those? :)

i.e. either remove default.nix or import default.nix from the flake.

@johanot johanot deleted the fix-vendor-sha-typo branch December 13, 2024 08:51
@cafkafk
Copy link
Member

cafkafk commented Dec 13, 2024

i.e. either remove default.nix or import default.nix from the flake.

I think some people (e.g. srhb) likes the default.nix to be around so she can avoid touching flakes if nescesarry, so we should probably import that (well, or move the package definition from the flake.nix into default.nix since it has some additional attrs from a glance, like mainProgram).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants