feat: speacial args (from #190) #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
commented
Sep 10, 2024
I.e. I could easily have broke something or special args may not work... I did try pretty hard not do break any conflicts with new features, like 7c94672, 8e01ad8 or https://github.com/DBCDK/morph/pull/214/files |
|
closed in favor of #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've resolved the conflicts from #190, but I don't wanna force push over it
because it was... pretty involved, and in case I've manage to break
something, having the original state around is pretty nice.
fwiw, in hindsight, I should have just cherry picked
633852a.
...ohh well...