Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1438 dd-manage-deposits improvements fixes for DD-1419 - Part 1 #4

Conversation

aliassheikh
Copy link
Contributor

Fixes DD-1438 dd-manage-deposits: Fix problems found DD-1419

Description of changes

These two changes are important improvements.

  • Using smaller time interval range to check the inbox and outbox folders
  • Check de content of the deposit.properties file every time when they are moved
    One other improvements will follow soon.

How to test

Related PRs

(Add links)

Notify

@DANS-KNAW/core-systems

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (05cc7f4) 0.00% compared to head (3ec1390) 0.00%.

Files Patch % Lines
...nagedeposit/core/service/DepositStatusUpdater.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master      #4   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          15      15           
  Lines         327     323    -4     
  Branches       19      18    -1     
======================================
+ Misses        327     323    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aliassheikh aliassheikh marked this pull request as draft February 23, 2024 15:46
@aliassheikh aliassheikh closed this Mar 9, 2024
@aliassheikh aliassheikh deleted the DD-1438-Fix-problems-found-DD1419 branch March 9, 2024 16:55
@aliassheikh aliassheikh self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants