-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD-1586 Added truncate-notifications with commandline input parsing #6
DD-1586 Added truncate-notifications with commandline input parsing #6
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
=============================================
+ Coverage 0 32.42% +32.42%
- Complexity 0 50 +50
=============================================
Files 0 30 +30
Lines 0 404 +404
Branches 0 14 +14
=============================================
+ Hits 0 131 +131
- Misses 0 267 +267
- Partials 0 6 +6 ☔ View full report in Codecov by Sentry. |
src/main/java/nl/knaw/dans/dvcli/command/NotificationTruncate.java
Outdated
Show resolved
Hide resolved
src/main/java/nl/knaw/dans/dvcli/command/NotificationTruncate.java
Outdated
Show resolved
Hide resolved
src/test/java/nl/knaw/dans/dvcli/command/NotificationTruncateTest.java
Outdated
Show resolved
Hide resolved
src/test/java/nl/knaw/dans/dvcli/command/NotificationTruncateTest.java
Outdated
Show resolved
Hide resolved
src/main/java/nl/knaw/dans/dvcli/command/NotificationTruncate.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I did not check the SQL queries in detail.
Fixes DD-1586
Description of changes
Implement
dataverse truncate-notifications {--user <uid>|--all-users } <number-of-records-to-keep>
How to test
Deploy the role on a fresh lifesciences dev box:
Ssh into the box and run some commands and check the result.
Example:
Related PRs
(Add links)
Notify
@DANS-KNAW/core-systems