Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1605: unit test #5

Merged
merged 27 commits into from
Sep 2, 2024
Merged

DD-1605: unit test #5

merged 27 commits into from
Sep 2, 2024

Conversation

jo-pol
Copy link
Contributor

@jo-pol jo-pol commented Aug 13, 2024

Fixes DD-

Description of changes

  • added unit tests
  • added annotations to BatchProcessor because it did not fail fast on a missing action

How to test

Related PRs

Notify

@DANS-KNAW/core-systems

Copy link

codecov bot commented Aug 13, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@jo-pol jo-pol marked this pull request as ready for review August 22, 2024 08:16
@jo-pol jo-pol requested a review from a team as a code owner August 22, 2024 08:16
@jo-pol jo-pol changed the title Test DD-1575: unit test Aug 29, 2024
@jo-pol jo-pol changed the title DD-1575: unit test DD-1605: unit test Aug 29, 2024
Copy link
Contributor

@PaulBoon PaulBoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jo-pol jo-pol merged commit be134dd into DANS-KNAW:master Sep 2, 2024
4 checks passed
@jo-pol jo-pol deleted the test branch September 2, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants