Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource version.txt #3

Closed
wants to merge 3 commits into from
Closed

resource version.txt #3

wants to merge 3 commits into from

Conversation

jo-pol
Copy link
Contributor

@jo-pol jo-pol commented Jul 3, 2024 •
edited
Loading

Fixes DD-

Description of changes

How to test

  • before compile and deploy dataverse --version throws IllegalStateException: Version file not found
  • after, it prints 0.3.1-SNAPSHOT
  • remove snapshot for dans-java-utils when library is published

Related PRs

depends on

Notify

@DANS-KNAW/core-systems

@jo-pol jo-pol requested a review from a team as a code owner July 3, 2024 12:42
@janvanmansum
Copy link
Contributor

@jo-pol : I am confused; I thought you wanted to get rid of version.txt.

@jo-pol jo-pol mentioned this pull request Jul 4, 2024
Merged
@janvanmansum janvanmansum marked this pull request as draft July 5, 2024 08:56
@janvanmansum
Copy link
Contributor

No longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jo-pol @janvanmansum