Reward distributor improvements #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired distribution
NoahSaso
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #881 +/- ##
===============================================
+ Coverage 96.64% 96.67% +0.03%
===============================================
Files 241 241
Lines 65544 65993 +449
===============================================
+ Hits 63347 63802 +455
+ Misses 2197 2191 -6 ☔ View full report in Codecov by Sentry. |
NoahSaso
force-pushed
the
noah/distributor-fix
branch
from
aa30ec7 to
31c6813
Compare
JakeHartnell
approved these changes
Sep 11, 2024
NoahSaso
changed the title
NoahSaso
changed the title
bekauz
approved these changes
Sep 12, 2024
NoahSaso
force-pushed
the
noah/distributor-fix
branch
from
7ae6bd3 to
5267dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things:
Adds an undistributed rewards query to the distributor so that you can check how many rewards would be withdrawn.
Fixes a bug pausing an already expired linear distribution. This isn't a vulnerability, but it should be possible, and there was just a minor logic error.
Adds the ability to fund the most recent distribution, without knowing its ID. This is useful when creating CW20 distributions. Because we can't verify the sender of a CW20 token send contract execution, we can't allow creating new distributions with initial CW20 funds (since the contract owner must create new distributions). Instead, the DAO can create a distribution AND fund the latest distribution (without knowing its ID) in one proposal.
Adds an
open_fundingflag so the owner can decide if a distribution can be funded by accounts other than the owner. The owner can always fund a distribution.Fixes a bug causing pending rewards and undistributed rewards queries to fail if a linear distribution has not yet been funded.