Cast vote on proposal creation #799
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #799 +/- ##
===============================================
+ Coverage 96.17% 96.21% +0.03%
===============================================
Files 207 207
Lines 53401 53909 +508
===============================================
+ Hits 51359 51866 +507
- Misses 2042 2043 +1 ☔ View full report in Codecov by Sentry. |
|
CI for integrations testing is failing, but there is a fix for that here: #715 |
sir that is a bounties contract 😂 can you split up the CI fix into a separate pr pls <3 |
|
Le fix for CI: #801 |
thank you! |
NoahSaso
force-pushed
the
noah/auto-vote
branch
from
34622fe to
5b4cb1b
Compare
|
hey @JakeHartnell seems the CI is failing for a cache issue? how do we resolve it D: |
Yolo merge? Ran test tube locally and everything passed so 99% sure it will work... |
Resolves #798
This allows the proposer to cast a vote when creating a proposal, which also takes care of instant-passing proposals when the member with majority voting power proposes something (#759). It will fail if the proposer is not a member (when anyone may propose is enabled).
It works by simply chaining the vote execution function after the proposal creation. This makes it future proof by respecting all other relevant features (such as
min_voting_periodandallow_revoting, which would have been ignored by #776).