Skip to content

Commit

Permalink
Removed "text-light" and made all links for dark mode automatically j…
Browse files Browse the repository at this point in the history
…ust be white.

Changed link hover color to be darker so it is more visible.
Added a link to create a GitHub issue.
  • Loading branch information
That-Thing committed Nov 23, 2024
1 parent 2cd240e commit 17dcbb5
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 9 deletions.
4 changes: 3 additions & 1 deletion src/assets/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/*Light Colors*/
--background-light: #ced4de;
--color-light: #f4f4f1;
--color-light-hover: #d6d6d6;
--color-light-hover: #b7b7b7;
--color-light-items: #d8d8d8;
/*Bootstrap color overrides*/
--bs-primary: var(--color-primary);
Expand All @@ -24,6 +24,8 @@
:root {
--color-background: var(--background-dark);
--color-text: var(--color-light);
--color-link: var(--color-light);
--color-link-hover: var(--color-light-hover);
/*Bootstrap color overrides*/
--bs-body-color: var(--color-light);
--bs-card-bg: var(--color-dark-items);
Expand Down
10 changes: 7 additions & 3 deletions src/assets/main.css
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
@import "./base.css";

/* nav {
background-color: var(--navbar-bg);
} */
a {
color: var(--color-link);
}
a:hover {
color: var(--color-link-hover);
}

.nav-link, .navbar-brand {
color: var(--color-text);
}
Expand Down
11 changes: 6 additions & 5 deletions src/components/footerComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { faGithub } from '@fortawesome/free-brands-svg-icons';
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome';
</script>
<template>
<footer class="text-light py-4 mt-auto border-top border-dark d-none d-md-block">
<footer class="py-4 mt-auto border-top border-dark d-none d-md-block">
<div class="container">
<div class="row justify-content-between">
<!-- Left Section: Brand and Social Links -->
Expand All @@ -13,16 +13,17 @@ import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome';
<div class="d-flex">
<FontAwesomeIcon :icon="faGithub" size="2x" class="me-3" />
<div class="my-auto">
<a href="https://github.com/D-I-S-H/DISH-FE" class="text-light me-3">Frontend</a>
<a href="https://github.com/D-I-S-H/DISH-API" class="text-light me-3">Backend</a>
<a href="https://github.com/D-I-S-H/DISH-FE" class="me-3">Frontend</a>
<a href="https://github.com/D-I-S-H/DISH-API" class="me-3">Backend</a>
</div>
</div>
</div>
<!-- Right Section: Disclaimer and DMCA -->
<!-- Right Section: Disclaimer, privacy policy, bug report link -->
<div class="col-md-6 text-md-end">
<h6 class="fw-bold">Disclaimer</h6>
<p class="mb-3">Dining Information Served Here (DISH) is still in early development and may have bugs.</p>
<router-link to="/privacy" class="text-light">Privacy Policy</router-link>
<a href="https://github.com/D-I-S-H/DISH-FE/issues/new" class="me-3">Report Bug</a>
<router-link to="/privacy">Privacy Policy</router-link>
</div>
</div>
</div>
Expand Down

0 comments on commit 17dcbb5

Please sign in to comment.