Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: coin-support-utils createAccount #436

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

test: coin-support-utils createAccount #436

wants to merge 32 commits into from

Conversation

jhasuraj01
Copy link
Contributor

No description provided.

@jhasuraj01 jhasuraj01 self-assigned this Apr 12, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: de036aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jhasuraj01 jhasuraj01 marked this pull request as ready for review April 22, 2024 03:44
@jhasuraj01 jhasuraj01 changed the title test: coin-support-utils test: coin-support-utils createAccount Apr 22, 2024
irshadjsr21
irshadjsr21 requested changes Apr 30, 2024
View reviewed changes
packages/coin-support-utils/tests/01.common/01.mapDerivationPath/__fixtures__/valid.ts Outdated Show resolved Hide resolved
packages/coin-support-utils/tests/01.common/01.mapDerivationPath/index.ts
Comment on lines +6 to +11
fixtures.valid.forEach(({ name, input, output }) => {
test(name, () => {
const result = mapDerivationPath(input);
expect(result).toStrictEqual(output);
});
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs negative test cases as well

...-support-utils/tests/02.createAccount/01.createDerivationPathGenerator/__fixtures__/valid.ts Outdated Show resolved Hide resolved
packages/coin-support-utils/tests/02.createAccount/01.createDerivationPathGenerator/index.ts Outdated Show resolved Hide resolved
packages/coin-support-utils/tests/02.createAccount/01.createDerivationPathGenerator/index.ts Outdated Show resolved Hide resolved
packages/coin-support-utils/tests/02.createAccount/04.generateAddressesPerScheme/index.ts Outdated Show resolved Hide resolved
packages/coin-support-utils/tests/02.createAccount/05.makeCreateAccountsObservable/index.ts
});

test('should create new accounts', done => {
db.account.getAll.mockResolvedValue([]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this test to be configurable. Currently only one test case of this kind can be ran which is hardcoded in __mocks__/createAccountParams

packages/coin-support-utils/tests/02.createAccount/05.makeCreateAccountsObservable/index.ts
const observer: Observer<ICreateAccountEvent> = {
next: value => {
if (value.type === 'Account') {
expect(value.account).toBeDefined();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check if we getting the correct result

packages/coin-support-utils/tests/02.createAccount/05.makeCreateAccountsObservable/index.ts Outdated Show resolved Hide resolved
packages/coin-support-utils/tests/02.createAccount/05.makeCreateAccountsObservable/index.ts Outdated Show resolved Hide resolved
jhasuraj01 and others added 8 commits May 2, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irshadjsr21 irshadjsr21 Awaiting requested review from irshadjsr21

Assignees

@jhasuraj01 jhasuraj01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhasuraj01 @irshadjsr21