Code

UI Support for global SetViews#192

Code

Draft

fde31 wants to merge 43 commits intodevelopCycling74/rnbo-runner-panel:developfrom fde/viewsCycling74/rnbo-runner-panel:fde/viewsCopy head branch name to clipboard

+2,180-512

Commits

Commits on Jan 8, 2025

• added initial data model and messaging for managing GraphSetViews

  fde31

  committed
  4901ed9

  Copy full SHA for 4901ed9

• added GraphSetView UI shell

  Show description for 905353d
  fde31

  committed
  905353d

  Copy full SHA for 905353d

• PresetItemComp: fixed missing return type

  fde31

  committed
  1651548

  Copy full SHA for 1651548

• clean up SetView formatting

  fde31

  committed
  b787473

  Copy full SHA for b787473

• fixed console typos in error messaging

  fde31

  committed
  b3c75d8

  Copy full SHA for b3c75d8

• ParameterItem: include MIDI mapping display value in MIDI mapping indicator

  fde31

  committed
  24654ce

  Copy full SHA for 24654ce

• added genericMemo util to allow using React.memo for components with generic types

  fde31

  committed
  b8a7228

  Copy full SHA for b8a7228

• move Parameter MIDIMapping Wrapper to a HOC and make ParameterList support passing the actual ComponentType for the ParameterItem as well as extra props

  fde31

  committed
  07d53e9

  Copy full SHA for 07d53e9

• cleaned up comments in ParameterList component

  fde31

  committed
  ca706f1

  Copy full SHA for ca706f1

• moved SetViewDrawer to drawer.tsx

  fde31

  committed
  0fa17ba

  Copy full SHA for 0fa17ba

• setviews: render title at the top

  fde31

  committed
  989a3b4

  Copy full SHA for 989a3b4

• getPatcherInstanceParametersBySetView returns an OrderedSet to align with instance ParameterList signature

  fde31

  committed
  3c5f71c

  Copy full SHA for 3c5f71c

• simplified Parameter actions to not require the PatcherInstance to be passed, if the action actually needs it one can retrieve it from the state quite easily given param.instanceIndex

  fde31

  committed
  917a98e

  Copy full SHA for 917a98e

• first pass at adding a SetViewParameterList to render parameters contained in a SetView

  fde31

  committed
  6c0bae0

  Copy full SHA for 6c0bae0

• decoupled Meta Editing, MIDI mapping and title display from Parameter item and moved it to withMidiMapping Component while extending SetView Parameters with basic ordering and SetView removal menu

  fde31

  committed
  cb0ee0d

  Copy full SHA for cb0ee0d

• initial version of SetView parameter management

  fde31

  committed
  aeac1a0

  Copy full SHA for aeac1a0

• removed comment cruft

  fde31

  committed
  c497734

  Copy full SHA for c497734

• consolidated codepath for shifting parameter index in SetView param list

  fde31

  committed
  7106399

  Copy full SHA for 7106399

• sort set parameters by instance and param index for both, new sets as well as including all params in a set

  fde31

  committed
  5a0b69c

  Copy full SHA for 5a0b69c

• ensure unique set view name when creating a new set

  fde31

  committed
  e6e4b0c

  Copy full SHA for e6e4b0c

• tweaked Parameter HoCs to pass menu items and div props to parameter item to enable easier reusing

  fde31

  committed
  fcf14cf

  Copy full SHA for fcf14cf

• parameteritem: minor MIDI mapping indicator text tweak by dropping leading "MIDI"

  fde31

  committed
  ec57282

  Copy full SHA for ec57282

• fixed missing semicolon

  fde31

  committed
  45a7ded

  Copy full SHA for 45a7ded

• allow MIDI mapping and clearing on SetView

  fde31

  committed
  bb437c2

  Copy full SHA for bb437c2

• empty setviews are not actively MIDI mapping

  fde31

  committed
  288cc41

  Copy full SHA for 288cc41

• use instanceId as string rather than interpreting it constantly as integer index value

  fde31

  committed
  ec2a325

  Copy full SHA for ec2a325

• further clean up to refer to instances by id, not by index

  fde31

  committed
  ea873e5

  Copy full SHA for ea873e5

• fixed typo

  fde31

  committed
  f753957

  Copy full SHA for f753957

• fixed updateSetMeta to be aligned with recent meta action refactoring

  fde31

  committed
  83a297a

  Copy full SHA for 83a297a

• create unique name for new instance preset

  fde31

  committed
  dfc0573

  Copy full SHA for dfc0573

• create unique names for new Sets as well as new SetPresets

  fde31

  committed
  584bbee

  Copy full SHA for 584bbee

• presetitems: auto focus input when triggering renaming

  fde31

  committed
  7b76b5c

  Copy full SHA for 7b76b5c

• focus renaming input for sets and presets when submitting form

  fde31

  committed
  1a57f68

  Copy full SHA for 1a57f68

• validate setview, set and preset names to be unique and show input field error

  fde31

  committed
  a294bfe

  Copy full SHA for a294bfe

• added missing validateUniqueName callback dep for SetView and SetView item comps

  fde31

  committed
  722cb13

  Copy full SHA for 722cb13

• set and preset save actions: added optional arg to enable / disable uniquename generation

  fde31

  committed
  8699c23

  Copy full SHA for 8699c23

• instance and set presets now have overwrite support

  fde31

  committed
  44da659

  Copy full SHA for 44da659

• improved distinction between createSet and saveSet (overwrite) in the code and ensured that the confirm dialogue is always shown upon overwrite

  fde31

  committed
  9c58b55

  Copy full SHA for 9c58b55

• presets and sets: trim names

  fde31

  committed
  f766045

  Copy full SHA for f766045

• fixed parameter function name typos

  fde31

  committed
  2f71fac

  Copy full SHA for 2f71fac

• trim setview names

  fde31

  committed
  e9f4c0f

  Copy full SHA for e9f4c0f

• set view overwrite naming tweak

  fde31

  committed
  4720cc1

  Copy full SHA for 4720cc1

• Merge pull request #195 from Cycling74/fde/unique_renaming

  Show description for 2250351
  fde31

  authored
  2250351

  Copy full SHA for 2250351