Extend the writing and waiting functions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channel#read_stream catches EAGAIN errors, so the blocking_call wrapper was useless. On the other hand, the loop must perform a waitsocket to compensate for the lack of waiting from read_stream. Otherwise, the loops made the CPU run at full throttle. The native call to libssh2_channel_read_ex passed the size of the pointer instead of the size of the buffer to libssh2, making it always return tiny amounts of data. The allocated buffer was also never freed, so I use the stack instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request add new methods for writing data into the standard input of the remote process. It also fixes and extend the wait loops in order not to consume all the CPU like it did, and allows the caller to specify a block to be called at regular intervals instead of losing all the control.