Docker version #51
Open
Docker version #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CyberPunkMetalHead What do you think? |
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| argument_parser = ArgumentParser('Binance news sentiment bot.', formatter_class=ArgumentDefaultsHelpFormatter) |
There was a problem hiding this comment.
Could you add docker commands and arguments in the README file? I would like to try this on local.
There was a problem hiding this comment.
@rushabhshah011 You are welcome)
|
@Rybens92 @petar-petkov @CyberPunkMetalHead any reaction? |
|
Hey @AlexNik, should be able to review your code in the next couple of days. Though I'm seeing a conflict with the main file? |
|
@CyberPunkMetalHead ok, I'll solve conflicts |
* save and load coins_in_hand dictionary to/from json file * remove not needed comment
# Conflicts: # news-analysis.py
# Conflicts: # news-analysis.py
|
@CyberPunkMetalHead Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code to classes
Add command line arguments
Add Docker feature