Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all state and commands related to music to separate class
Proposed command renames:
/currentmusic -> /music showcurrent
/getmusic -> /music playlast
/jukebox_toggle -> /music mode (vote, queue, shuffle, normal)
/jukebox_skip -> /music skip
/jukebox -> /music info (show info about queue/votes) (maybe merge /music current into this one)
/play -> /music play
/play_once -> /music playonce (may be more sensible to have a setting to turn looping on and off)
/blockdj -> /music block
/unblockdj -> /music unblock
/musiclists -> /music showlists
/musiclist -> /music loadlist
/area_musiclist -> /music loadarealist
/hub_musiclist -> /music loadhublist
/random_music -> /music playrandom
/musiclist_save -> /music savelist
/musiclist_rebuild -> /music rebuildlist
/musiclist_remove -> /music removelist
/musiclist_add -> /music addlist
old commands can easily be aliased to new ones to keep them working if that's required
I see that client_manager has a lot of functions and state related to music too, but let's not dive into that right now.