Censor /status and allow for custom status to be set (requires KFO Client update) #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you name the PR descriptively, remember 1 PR per 1 core feature |
Crystalwarrior
requested changes
May 26, 2024
| @@ -2,7 +2,7 @@ | |||
| from server import commands | |||
| from server.evidence import EvidenceList | |||
| from server.exceptions import ClientError, AreaError, ArgumentError, ServerError | |||
| from server.constants import MusicEffect, derelative | |||
| from server.constants import MusicEffect, derelative, censor | |||
server/area.py
Outdated
| raise AreaError( | ||
| f'Invalid status. Possible values: {", ".join(allowed_values)}' | ||
| f'Invalid status. Possible values: {", ".join(possible_values)}' |
There was a problem hiding this comment.
Maybe just outward specify "hub" is a restricted value?
There was a problem hiding this comment.
So just specify in ooc "Hub" is a restricted status?
| @@ -647,7 +647,7 @@ def send_arup_status(self, clients=None): | |||
| return | |||
| status_list = [1] | |||
| if len(self.server.hub_manager.hubs) > 1: | |||
| status_list = [1, "GAMING"] | |||
| status_list = [1, "HUB"] | |||
There was a problem hiding this comment.
Pre-KFO Client might not display the right status color
There was a problem hiding this comment.
What version KFO client will be? so I can diversify from the old one
There was a problem hiding this comment.
any client that isn't KFO LOL
Crystalwarrior
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.