Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autovac worker metrics to sql_exporter and grafana #409

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

keithf4
Copy link
Collaborator

@keithf4 keithf4 commented May 14, 2024

Description

Add metrics to track autovac workers running vs max.

Original issue had reference to more extensive vacuum metrics and dashboard, but it's been taken down. It would've been optional anyway

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #106

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • SLES
  • Not applicable

If your code touches postgres_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 added this to the 5.1 milestone May 14, 2024
@keithf4 keithf4 self-assigned this May 14, 2024
@keithf4 keithf4 marked this pull request as ready for review May 15, 2024 15:07
@keithf4 keithf4 added the FEATURE New feature or request label May 15, 2024
hunleyd
hunleyd previously approved these changes May 16, 2024
jchancojr
jchancojr previously approved these changes May 17, 2024
YorviArias
YorviArias previously approved these changes May 29, 2024
@keithf4 keithf4 dismissed stale reviews from YorviArias, jchancojr, and hunleyd via 9e8e025 July 19, 2024 18:03
Copy link
Collaborator

@hunleyd hunleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

Copy link
Contributor

@jchancojr jchancojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending conflicts

Copy link

@YorviArias YorviArias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still has conflicts

@keithf4 keithf4 requested a review from hunleyd August 1, 2024 14:40
@keithf4 keithf4 merged commit 657c895 into CrunchyData:development Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vacuum analysis queries & dashboard
4 participants