Check extension at hooks #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Dec 16, 2024
src/parquet_copy_hook/copy_utils.rs
Outdated
| } | ||
|
|
||
| pub(crate) fn is_copy_from_parquet_stmt(p_stmt: &PgBox<PlannedStmt>) -> bool { | ||
| // the GUC pg_parquet.enable_copy_hook must be set to true | ||
| if !ENABLE_PARQUET_COPY_HOOK.get() { |
There was a problem hiding this comment.
thanks, this looks a bit cleaner
src/parquet_copy_hook/copy_utils.rs
Outdated
|
|
||
| // extension checks are done via catalog (not yet searched via cache by postgres till pg18) | ||
| // this is why we check them after the uri checks | ||
| extension_exists("pg_parquet") && !extension_exists("crunchy_query_engine") |
There was a problem hiding this comment.
thinking out loud: maybe we return silently if crunchy_query_engine exists, but throw a warning/notice if pg_parquet does not exist?
marcoslot
approved these changes
Dec 16, 2024
marcoslot
reviewed
Dec 16, 2024
marcoslot
reviewed
Dec 16, 2024
src/parquet_copy_hook/copy_utils.rs
Outdated
|
|
||
| if !copy_stmt.is_from { | ||
| // crunchy_query_engine should not be created | ||
| if extension_exists("crunchy_query_engine") { |
There was a problem hiding this comment.
if this is the case, we want pg_parquet to be silent (should come before)
aykut-bozkurt
force-pushed
the
aykut/check-extension
branch
from
3f4ce54 to
199c832
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 92.18% 92.11% -0.08%
==========================================
Files 71 71
Lines 9087 9104 +17
==========================================
+ Hits 8377 8386 +9
- Misses 710 718 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be confusing for some users that hooks are still running (since at shared_preload_libraries) even if the extension is dropped. Hence, we decided to process parquet copy hooks only when
pg_parquetextension is created.