refactor: modularize tests #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
force-pushed
the
aykut/coerce-types-on-read
branch
2 times, most recently
from
78fc3c9 to
ed3e766
Compare
`COPY FROM parquet` is too strict when matching Postgres tupledesc schema to the parquet file schema.
e.g. `INT32` type in the parquet schema cannot be read into a Postgres column with `int64` type.
We can avoid this situation by casting arrow array to the array that is expected by the tupledesc
schema, if the cast is possible. We can make use of `arrow-cast` crate, which is in the same project
with `arrow`. Its public api lets us check if a cast possible between 2 arrow types and perform the cast.
To make sure the cast is possible, we need to do 2 checks:
1. arrow-cast allows the cast from "arrow type at the parquet file" to "arrow type at the schema that is
generated for tupledesc",
2. the cast is meaningful at Postgres. We check if there is an explicit cast from "Postgres type that corresponds
for the arrow type at Parquet file" to "Postgres type at tupledesc".
With that we can cast between many castable types as shown below:
- INT16 => INT32
- UINT32 => INT64
- FLOAT32 => FLOAT64
- LargeUtf8 => UTF8
- LargeBinary => Binary
- Struct, Array, and Map with castable fields, e.g. [UINT16] => [INT64] or struct {'x': UINT16} => struct {'x': INT64}
**NOTE**: Struct fields must match by name and position to be cast.
Closes #67.
aykut-bozkurt
force-pushed
the
aykut/coerce-types-on-read
branch
from
ed3e766 to
b408fac
Compare
aykut-bozkurt
force-pushed
the
aykut/modularize-tests
branch
from
c69fd25 to
25d6e69
Compare
marcoslot
reviewed
Nov 25, 2024
src/pgrx_tests/common.rs
Outdated
| CopyOptionValue::StringOption("parquet".to_string()), | ||
| ); | ||
|
|
||
| let uri = "/tmp/test.parquet".to_string(); |
There was a problem hiding this comment.
maybe should use more obscure file names. A user/developer might have an unrelated file named this way and get very confused
marcoslot
approved these changes
Nov 25, 2024
src/pgrx_tests/common.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub(crate) fn test_helper<T: IntoDatum + FromDatum + Debug + PartialEq>(test_table: TestTable<T>) { |
There was a problem hiding this comment.
could be nice to have a more descriptive name here now that things are getting more dispersed, e.g. test_export_import_equality test_round_trip_equality
aykut-bozkurt
force-pushed
the
aykut/modularize-tests
branch
from
25d6e69 to
c59b9b7
Compare
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 91.94% 92.01% +0.06%
==========================================
Files 62 70 +8
Lines 8795 8879 +84
==========================================
+ Hits 8087 8170 +83
- Misses 708 709 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single test file gets bigger and bigger. Lets have separate test files for different scenarios.