-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pg{14,15} to support matrix #57
Conversation
5d3bd72
to
10aceaa
Compare
10aceaa
to
164ad14
Compare
e79f486
to
8a2d1cd
Compare
CI is now fixed, and Pg 13 is failing for the correct reasons... (Always important to distinguish there... 😁) So doing a little brain dump on what I'm seeing here. I have a theory and an instinct for what is going on, but need to dig more. So there is a test failure with Pg 13, but it's happening at an unexpected point which is the "validate success" test path:
Per git logs, this sounds like this is related to postgres/postgres@670c0a1d47 which was only backported to 14, so this would be why we're getting this error from PG 13, and the backtrace backs it up:
A possible solution for PG 13 support could be to switch to text mode instead of binary mode here (presumably only for Pg 13), or to forbid arrays of user-defined composite types when using Pg 13. (There may be other solutions, but this seems to be where the issue comes in.) In any case, I think the recommendation at this point is to merge support for 14-17 for now and open a second PR with 13 support, to the extent we can get it. |
3 functions need to be ported to support PG{14,15}.
pg_analyze_and_rewrite
for pg14pg_analyze_and_rewrite_fixedparams
for >=pg15Value
for pg14String
for >= pg15EmitWarningsOnPlaceholders
for pg14MarkGUCPrefixReserved
for >= pg15