Support reading s3 config from config file #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a parquet dest receiver to write parquet file from the table or query.
…tocol to populate tables from parquet file.
- adds a GUC, named "pg_parquet.enable_copy_hooks", which enables/disabled the hook, - exposes parquet dest receiver api so that the dest receiver could be used independently from the hook.
- adds "parquet.metadata", "parquet.file_metadata", and "parquet.kv_metadata" udfs to inspect the metadata of a parquet file.
marcoslot
reviewed
Oct 2, 2024
| echo AWS_SECRET_ACCESS_KEY=${{ env.AWS_SECRET_ACCESS_KEY }} >> /tmp/.env | ||
| echo AWS_REGION=${{ env.AWS_REGION }} >> /tmp/.env | ||
| echo AWS_S3_TEST_BUCKET=${{ env.AWS_S3_TEST_BUCKET }} >> /tmp/.env | ||
| echo PG_PARQUET_TEST=${{ env.PG_PARQUET_TEST }} >> /tmp/.env |
There was a problem hiding this comment.
would be kind of nice to write an actual .aws/credentials to confirm this PR works
There was a problem hiding this comment.
we unset env vars in the s3 tests while reading from config.
marcoslot
reviewed
Oct 2, 2024
|
|
||
| pub async fn get_s3_object_store(bucket_name: &str) -> AmazonS3 { | ||
| // try loading the .env file | ||
| dotenvy::from_path("/tmp/.env").ok(); |
There was a problem hiding this comment.
weird absolute path, was this meant for a test?
There was a problem hiding this comment.
yeah, but we can use .env in current path.
There was a problem hiding this comment.
current path causes problems as it looks up the folder where the binary exists. I think /tmp is ok. It is already fail safe when we call .ok() which means swallow error if any.
aykut-bozkurt
force-pushed
the
add-readme
branch
from
7446ed6 to
e44d6f5
Compare
|
Moved to #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.