Add copy hook utils module #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Oct 2, 2024
src/parquet_copy_hook/copy_utils.rs
Outdated
| } | ||
|
|
||
| pub(crate) fn validate_copy_from_options(pstmt: &PgBox<pg_sys::PlannedStmt>) { | ||
| let allowed_options = ["format"]; |
There was a problem hiding this comment.
do we want to allow freeze? (and propagate that into copy logic)
marcoslot
reviewed
Oct 2, 2024
|
|
||
| let mut found_parquet_format = false; | ||
| let mut copy_options = unsafe { PgList::<DefElem>::from_pg(copy_stmt.options) }; | ||
| for option in copy_options.iter_ptr() { |
There was a problem hiding this comment.
it wasn't quite clear to me why we're looking for the format here
this function seems to do more than its name suggests
There was a problem hiding this comment.
Made it copy_from_stmt_add_or_update_binary_format_option
There was a problem hiding this comment.
still a bit confusing to me, we probably want to build a new options list for internal use containing options like: format 'binary' (always), freeze (if present in the original list)
marcoslot
reviewed
Oct 2, 2024
src/parquet_copy_hook/copy_utils.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub(crate) fn copy_relation_oid(pstmt: &PgBox<pg_sys::PlannedStmt>) -> Oid { |
There was a problem hiding this comment.
copy looks more like a verb here
maybe copy_statement_relation_oid, copy_statement_lock_mode
aykut-bozkurt
force-pushed
the
parquet-reader
branch
from
8109012 to
09698ac
Compare
aykut-bozkurt
force-pushed
the
copy-hook-utils
branch
from
3f87cc1 to
3627d3d
Compare
|
Addressed at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.