Read arrow array from parquet file #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Oct 2, 2024
| self.copy_finish(); | ||
| } | ||
|
|
||
| true |
There was a problem hiding this comment.
do we ever return false?
There was a problem hiding this comment.
no, it stops when buffer is not updated.
marcoslot
reviewed
Oct 2, 2024
src/arrow_parquet/parquet_reader.rs
Outdated
| self.offset = 0; | ||
| } | ||
|
|
||
| fn copy_start(&mut self) { |
There was a problem hiding this comment.
this file could use some comments on what we're doing here
(e.g. why are we converting to binary copy protocol format? what would we do we with the buffer?)
aykut-bozkurt
force-pushed
the
arrow-to-pg
branch
from
047ff2e to
c2c8fa3
Compare
aykut-bozkurt
force-pushed
the
parquet-reader
branch
from
8109012 to
09698ac
Compare
|
Addressed at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.