Parse arrow and parquet schema from PG table's tuple descriptor #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Oct 2, 2024
| field_id.to_string(), | ||
| )]); | ||
|
|
||
| *field_id += 1; |
There was a problem hiding this comment.
kind of wondering whether we should be slightly cleverer about field IDs to not instantly renumber everything if a column gets dropped
(but no great ideas there)
marcoslot
reviewed
Oct 2, 2024
| } else { | ||
| Field::new(elem_name, arrow::datatypes::DataType::Utf8, true) | ||
| } | ||
| } |
There was a problem hiding this comment.
maybe add a comment on interval / other things that we'd like to have in this list
marcoslot
reviewed
Oct 2, 2024
src/arrow_parquet/schema_visitor.rs
Outdated
| Schema::new(Fields::from(struct_attribute_fields)) | ||
| } | ||
|
|
||
| fn visit_struct_schema(tupledesc: PgTupleDesc, elem_name: &str, field_id: &mut i32) -> Arc<Field> { |
There was a problem hiding this comment.
could use function comments, visit is vague
marcoslot
reviewed
Oct 2, 2024
| @@ -0,0 +1,290 @@ | |||
| use std::{collections::HashMap, ops::Deref, sync::Arc}; | |||
There was a problem hiding this comment.
would be good to add a high-level description at the top of the file of what it does. schema_visitor is vague
Parses arrow and parquet schema from PG table's tuple descriptor. Ensures the tupledesc and the schema matches.
aykut-bozkurt
force-pushed
the
fallback-type
branch
from
5521f97 to
18e6b64
Compare
aykut-bozkurt
force-pushed
the
schema-parse
branch
from
81bc0d5 to
c235a23
Compare
|
Addressed at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.