Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PG function declerations that are not generated by pgrx yet #18

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

aykut-bozkurt
Copy link
Collaborator

These pg function declarations are not yet generated by pgrx. We will get rid of it when they are declared.

PgBox,
};

#[allow(improper_ctypes)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #16, do you need the pg_guard annotation?

Copy link
Collaborator

@marcoslot marcoslot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll remove this as part of replaying commit history, but probably good to add the pg_guard in case we run into some crashes along the way.

@aykut-bozkurt aykut-bozkurt merged commit 86f3534 into crunchy_main Sep 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants