Adds pgrx utility functions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
commented
Sep 23, 2024
| @@ -1,3 +1,6 @@ | |||
| [target.'cfg(target_os="macos")'] | |||
| # Postgres symbols won't be available until runtime | |||
| rustflags = ["-Clink-arg=-Wl,-undefined,dynamic_lookup"] | |||
|
|
|||
| [net] | |||
| git-fetch-with-cli = true | |||
There was a problem hiding this comment.
aykut-bozkurt
commented
Sep 23, 2024
|
|
||
| [[bin]] | ||
| name = "pgrx_embed_pg_parquet" | ||
| path = "./src/bin/pgrx_embed.rs" | ||
|
|
||
| [features] | ||
| default = ["pg16"] |
There was a problem hiding this comment.
will add pg17 later
aykut-bozkurt
changed the title
marcoslot
approved these changes
Sep 25, 2024
| PgTupleDesc, | ||
| }; | ||
|
|
||
| pub(crate) fn collect_valid_attributes( |
There was a problem hiding this comment.
would be good to add comments,
"valid" has a very specific meaning here
There was a problem hiding this comment.
let me add it when I include docs. I open an issue to track it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.