Skip to content

Commit

Permalink
Merge pull request #462 from Crunch-io/fix-wrong-pytest-skipif-clause
Browse files Browse the repository at this point in the history
fix pytest skipif wrong clause in integration/test_expressions
  • Loading branch information
aless10 authored Jul 24, 2024
2 parents fe22416 + 41d43c8 commit c5e836f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions integration/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def test_replace_values(self):
finally:
ds.delete()

@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is not None, reason="Do not run this test during CI/CD")
@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is None, reason="Do not run this test during CI/CD")
def test_append_dataset(self):
ds = self.site.datasets.create(as_entity({"name": "test_scrunch_append_dataset"})).refresh()
ds.variables.create(
Expand Down Expand Up @@ -130,7 +130,7 @@ def test_append_dataset(self):
ds.delete()
ds_to_append.delete()

@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is not None, reason="Do not run this test during CI/CD")
@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is None, reason="Do not run this test during CI/CD")
def test_append_dataset_with_filter(self):
ds = self.site.datasets.create(as_entity({"name": "test_scrunch_append_dataset"})).refresh()
ds.variables.create(
Expand Down Expand Up @@ -227,7 +227,7 @@ def test_append_dataset_with_filter(self):
ds.delete()
ds_to_append.delete()

@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is not None, reason="Do not run this test during CI/CD")
@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is None, reason="Do not run this test during CI/CD")
def test_append_dataset_with_filter_and_exclusion(self):
ds = self.site.datasets.create(as_entity({"name": "test_scrunch_append_dataset_with_filter_exclusion"})).refresh()
ds.variables.create(
Expand Down Expand Up @@ -325,7 +325,7 @@ def test_append_dataset_with_filter_and_exclusion(self):
ds.delete()
ds_to_append.delete()

@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is not None, reason="Do not run this test during CI/CD")
@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is None, reason="Do not run this test during CI/CD")
def test_append_dataset_with_variables_list_and_exclusion(self):
ds = self.site.datasets.create(as_entity({"name": "test_scrunch_append_dataset_with_variable_exclusion"})).refresh()
ds.variables.create(
Expand Down Expand Up @@ -422,7 +422,7 @@ def test_append_dataset_with_variables_list_and_exclusion(self):
ds.delete()
ds_to_append.delete()

@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is not None, reason="Do not run this test during CI/CD")
@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is None, reason="Do not run this test during CI/CD")
def test_append_dataset_with_variables_list_filters_and_exclusion(self):
ds = self.site.datasets.create(as_entity({
"name": "test_scrunch_append_dataset_with_variable_filters_exclusion"
Expand Down
2 changes: 1 addition & 1 deletion integration/test_expressions.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from scrunch.mutable_dataset import get_mutable_dataset


@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is not None, reason="Do not run this test during CI/CD")
@pytest.mark.skipif(os.environ.get("LOCAL_INTEGRATION") is None, reason="Do not run this test during CI/CD")
class TestExpressions(BaseIntegrationTestCase):

def _create_mr_dataset(self, name, rows):
Expand Down

0 comments on commit c5e836f

Please sign in to comment.