Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new falcon hosts dynamic inventory plugin #470

Merged
merged 4 commits into from
Mar 17, 2024

Conversation

carlosmmatos
Copy link
Contributor

@carlosmmatos carlosmmatos commented Mar 16, 2024

This plugin will query our Falcon Hosts API to retrieve all the details associated to the requested filter query.

Closes #458

This plugin will query our Falcon Hosts API to retrieve all the details associated
to the requested filter query.
@carlosmmatos carlosmmatos added enhancement New feature or request minor_changes New features, like plugin or module options new_release feature_request labels Mar 16, 2024
@carlosmmatos carlosmmatos self-assigned this Mar 16, 2024
@carlosmmatos carlosmmatos marked this pull request as ready for review March 16, 2024 00:39
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 20.72072% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 37.83%. Comparing base (f3975ea) to head (b459c36).

Files Patch % Lines
plugins/inventory/falcon_hosts.py 20.72% 88 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   40.50%   37.83%   -2.68%     
==========================================
  Files          16       17       +1     
  Lines         711      822     +111     
  Branches      135      158      +23     
==========================================
+ Hits          288      311      +23     
- Misses        422      510      +88     
  Partials        1        1              
Flag Coverage Δ
sanity 37.83% <20.72%> (-2.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

redhatrises
redhatrises previously approved these changes Mar 16, 2024
@carlosmmatos carlosmmatos merged commit cda4f20 into CrowdStrike:main Mar 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature_request minor_changes New features, like plugin or module options new_release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access denied in ansible inventory
3 participants