-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite scroll/merge components ranges #4620
Open
benwolski
wants to merge
77
commits into
develop
Choose a base branch
from
infinite-scroll/merge_components_ranges
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-scroll/limit-order-fake-row
…s_ranges' into infinite-scroll/merge_components_ranges
…s_ranges' into infinite-scroll/merge_components_ranges
✅ Deploy Preview for futa-finance ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for base-ambient-finance ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-ambi ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…scroll/merge_components_ranges
…ts_ranges Add refresher for user pool positions
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
All infinite scroll implementation has been merged into a single component named
InfiniteScroll.tsx
Detailed information about component is located on
.../InfiniteScroll/inf_usage.md
fileThat component has been injected into
Transactions.tsx
,Orders.tsx
andRanges.tsx
3 hooks are created to use as helpers
useInfiniteScrollFetchers
: to locate fetcher functions for each tab and their casesuseMergeWithPendingTxs
: to merge pending transaction objects with related table listuseGenFakeTableRow
: to create synthetic LimitOrderIF and PositionIF objects to render pending transactions on Limit and Liquidity tabsLink the related issue
Closes #0000
Checklist before requesting a review
docs/CODING-STYLE.md
?Instructions for Reviewers
Functionalities or workflows that should specifically be tested.
Environmental conditions that may result in expected but differential behavior.
If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)