Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite scroll/merge components ranges #4620

Open
wants to merge 77 commits into
base: develop
Choose a base branch
from

Conversation

benwolski
Copy link
Collaborator

@benwolski benwolski commented Jan 13, 2025

Describe your changes

All infinite scroll implementation has been merged into a single component named InfiniteScroll.tsx

Detailed information about component is located on .../InfiniteScroll/inf_usage.md file

That component has been injected into Transactions.tsx, Orders.tsx and Ranges.tsx
3 hooks are created to use as helpers

  • useInfiniteScrollFetchers: to locate fetcher functions for each tab and their cases
  • useMergeWithPendingTxs: to merge pending transaction objects with related table list
  • useGenFakeTableRow: to create synthetic LimitOrderIF and PositionIF objects to render pending transactions on Limit and Liquidity tabs

Link the related issue

Closes #0000

Checklist before requesting a review

  • Is this PR ready for merge? (Please convert to a draft PR otherwise)
  • I have performed a self-review of my code.
  • Did I request feedback from a team member prior to the merge?
  • Does my code following the style guide at docs/CODING-STYLE.md?

Instructions for Reviewers

Functionalities or workflows that should specifically be tested.

Environmental conditions that may result in expected but differential behavior.

If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for futa-finance ready!

Name Link
🔨 Latest commit b7f6ae5
🔍 Latest deploy log https://app.netlify.com/sites/futa-finance/deploys/6786d07a288fd900083d893f
😎 Deploy Preview https://deploy-preview-4620--futa-finance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for base-ambient-finance ready!

Name Link
🔨 Latest commit b7f6ae5
🔍 Latest deploy log https://app.netlify.com/sites/base-ambient-finance/deploys/6786d07a8d277f0008700c2b
😎 Deploy Preview https://deploy-preview-4620--base-ambient-finance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for dev-ambi ready!

Name Link
🔨 Latest commit b7f6ae5
🔍 Latest deploy log https://app.netlify.com/sites/dev-ambi/deploys/6786d07bcc57850008f896bd
😎 Deploy Preview https://deploy-preview-4620--dev-ambi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants