Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Searchable Ticker #4558

Merged
merged 68 commits into from
Dec 27, 2024
Merged

Style Searchable Ticker #4558

merged 68 commits into from
Dec 27, 2024

Conversation

emilydrakesmith
Copy link
Contributor

Describe your changes

Describe the purpose + content of these changes

Link the related issue

Closes #0000

Checklist before requesting a review

  • Is this PR ready for merge? (Please convert to a draft PR otherwise)
  • I have performed a self-review of my code.
  • Did I request feedback from a team member prior to the merge?
  • Does my code following the style guide at docs/CODING-STYLE.md?

Instructions for Reviewers

Functionalities or workflows that should specifically be tested.

Environmental conditions that may result in expected but differential behavior.

If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)

@emilydrakesmith
stub up state management in Account.tsx file
b508432
@emilydrakesmith
filter data set by created vs all bids
0644ae7
@emilydrakesmith
move header of SearchableTicker.tsx into return
3fa2b19
@emilydrakesmith
remove deprecated code from SearchableTicker.tsx file
a034a13
@emilydrakesmith
update all returns in Account.tsx to consume filtered auctions list
ba15c53
@emilydrakesmith
Merge branch 'develop' of https://github.com/CrocSwap/ambient-ts-app …
cddd687 
…into avalon
@emilydrakesmith
stub up functionality of toggle buttons in SearchableTicker.tsx file
6ccd1df
@emilydrakesmith
commit to allow push
8635e2e
@emilydrakesmith
remove temp Switch View button from Account.tsx file
0aec041
@emilydrakesmith
toggle color of active bids or created button
e0f1bf7
@emilydrakesmith
Merge branch 'develop' of https://github.com/CrocSwap/ambient-ts-app …
ae79c32 
…into avalon
@emilydrakesmith
change Account.tsx table filter layout to CSS grid
89c9ecc
@emilydrakesmith
style Account.tsx table options for mobile devices
885f688
@emilydrakesmith
remove title from mobile version of FUTA account page
5d8a5d0
@emilydrakesmith
fix initialization bug in Account.tsx file
3d281f2
@emilydrakesmith
annotate new code in Account.tsx file
3ab00c3
@emilydrakesmith
suppress column headers in SearchableTicker.tsx file when no data i…
ace4a16 
…s present
@emilydrakesmith
visually center 'No tickers to display' message
ae85d07
@emilydrakesmith
reinsert sorted to sort logic
9270518
@emilydrakesmith
update bids/created button highlighting
69ba411
@emilydrakesmith
revert bids vs created button styling on mobile devices
84a317f
@emilydrakesmith
Merge branch 'develop' of https://github.com/CrocSwap/ambient-ts-app …
2cab894 
…into avalon
@emilydrakesmith
re-enable data filtering and sorting
15116a9
@emilydrakesmith
delete deprecated CSS rules
4bb4fb8
@emilydrakesmith
group search and sort elements in SearchableTicker.tsx file
211f278
@emilydrakesmith
add border to buttons in active state
53e2b9f
@emilydrakesmith
delete deprecated CSS from SearchableTicker.tsx file
6c378c7
@emilydrakesmith
complete mobile styling on header
d5c8a78
@emilydrakesmith
Merge branch 'develop' of https://github.com/CrocSwap/ambient-ts-app …
3786ef4 
…into spectre
@emilydrakesmith
add bottom margin to header
0849c2f
@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for plume-ambient-finance ready!

Name Link
🔨 Latest commit fad8ac1
🔍 Latest deploy log https://app.netlify.com/sites/plume-ambient-finance/deploys/676f1430e41dee0008670a5a
😎 Deploy Preview https://deploy-preview-4558--plume-ambient-finance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for dev-ambi ready!

Name Link
🔨 Latest commit fad8ac1
🔍 Latest deploy log https://app.netlify.com/sites/dev-ambi/deploys/676f1430fcdba30008411b1c
😎 Deploy Preview https://deploy-preview-4558--dev-ambi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for futa-finance ready!

Name Link
🔨 Latest commit fad8ac1
🔍 Latest deploy log https://app.netlify.com/sites/futa-finance/deploys/676f143001658c0008ea613c
😎 Deploy Preview https://deploy-preview-4558--futa-finance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for base-ambient-finance ready!

Name Link
🔨 Latest commit fad8ac1
🔍 Latest deploy log https://app.netlify.com/sites/base-ambient-finance/deploys/676f14302f064f0008bc8ad4
😎 Deploy Preview https://deploy-preview-4558--base-ambient-finance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emilydrakesmith and others added 14 commits December 27, 2024 11:12
@emilydrakesmith
remove differential action for showComplete on Account page
828fbab
@emilydrakesmith
Merge branch 'develop' of https://github.com/CrocSwap/ambient-ts-app …
4095db3 
…into spectre
@emilydrakesmith
remove developmental outline styling
350000e
@emilydrakesmith
remove watchlist filtering on Account page
f2540a6
@emilydrakesmith
remove developmental console logging
5ae777b
@benwolski
add E09 address as created by for testing
83a9963
@emilydrakesmith
highlight active ticker on Auctions page
af0b4ef
@emilydrakesmith
Merge branch 'spectre' of https://github.com/CrocSwap/ambient-ts-app …
c963190 
…into spectre
@emilydrakesmith
annotate new CSS class logic in TickerItem.tsx file
9c6693a
@emilydrakesmith
complete color change for active and hovered tickers on Auctions page
ca34de8
@emilydrakesmith
simplify code to change ticker background color
3113a24
@emilydrakesmith
remove deprecated developmental code
e7e4eac
@emilydrakesmith
add animation to background color changes in ticker line items
4f9f5a1
@emilydrakesmith
remove deprecated CSS from searchable ticker files
ccdc62d
@emilydrakesmith emilydrakesmith marked this pull request as ready for review December 27, 2024 17:32
@emilydrakesmith emilydrakesmith requested review from Jadessu and benwolski and removed request for Jadessu December 27, 2024 17:32
@emilydrakesmith emilydrakesmith self-assigned this Dec 27, 2024
@benwolski benwolski merged commit 564a679 into develop Dec 27, 2024
11 of 14 checks passed
@benwolski benwolski deleted the spectre branch December 27, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwolski benwolski benwolski approved these changes

@Jadessu Jadessu Awaiting requested review from Jadessu

Assignees

@emilydrakesmith emilydrakesmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilydrakesmith @benwolski