Add isPage()
fn to useLinkGen()
hook
#3612
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
useLinkGen()
hookisPage()
method to the logic housed and returned by theuseLinkGen()
hookLink the related issue
Closes #3611
Checklist before requesting a review
docs/CODING-STYLE.md
?Instructions for Reviewers
Functionalities or workflows that should specifically be tested.
I refactored
App.tsx
to use the new logic to determine on what pages the left sidebar should render. Poke around the app, look for pages where the sidebar appears but shouldn't or fails to appear when it should.Environmental conditions that may result in expected but differential behavior.
None!
If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)
This goal of this PR is to make new centralized logic available for ongoing development and instantiate it in
App.tsx
for proof-of-concept. The app will still need a wider refactor to replace all instances of old logic with the new centralized process.