Skip to content

Commit

Permalink
Merge pull request #4367 from CrocSwap/apply-prettier-to-all-files-no…
Browse files Browse the repository at this point in the history
…v-20

apply prettier to all files
  • Loading branch information
benwolski authored Nov 20, 2024
2 parents 71e885b + 2737a9d commit 86c8c8a
Show file tree
Hide file tree
Showing 244 changed files with 6,083 additions and 4,487 deletions.
26 changes: 13 additions & 13 deletions .github/ISSUE_TEMPLATE/DEBT.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
name: Technical Debt
description: File technical debt
title: "[Tech Debt]: "
labels: ["technical debt"]
title: '[Tech Debt]: '
labels: ['technical debt']
body:
- type: markdown
attributes:
value: "Thanks for taking the time to document deferred engineering work!"
- type: textarea
id: work-required
attributes:
label: What is needed?
description: Tell / show what work is being deferred, (link back to the codebase with TODO if possible).
placeholder: What work is being deferred? (NOTE solutioning is not needed here)
validations:
required: true
- type: markdown
attributes:
value: 'Thanks for taking the time to document deferred engineering work!'
- type: textarea
id: work-required
attributes:
label: What is needed?
description: Tell / show what work is being deferred, (link back to the codebase with TODO if possible).
placeholder: What work is being deferred? (NOTE solutioning is not needed here)
validations:
required: true
58 changes: 29 additions & 29 deletions .github/ISSUE_TEMPLATE/NEW.yml
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
name: Enhancement
description: File an Enhancement
title: "[Enhancement]: "
labels: ["enhancement"]
title: '[Enhancement]: '
labels: ['enhancement']
body:
- type: markdown
attributes:
value: "Thanks for taking the time to fill out this ticket!"
- type: textarea
id: requirements
attributes:
label: Requirements
description: Tell / show the feature requirements, screenshots are helpful!
placeholder: e.x. A new modal needs to open when the user...
validations:
required: true
- type: textarea
id: figma
attributes:
label: Figma
description: Drop a Figma link if this enhancement impacts the UX.
placeholder: https://...
validations:
required: false
- type: textarea
id: assumptions
attributes:
label: Assumptions
description: What are the underlying assumptions guiding implementation?
placeholder: e.x. 1. users are not able to access this modal without...
validations:
required: false
- type: markdown
attributes:
value: 'Thanks for taking the time to fill out this ticket!'
- type: textarea
id: requirements
attributes:
label: Requirements
description: Tell / show the feature requirements, screenshots are helpful!
placeholder: e.x. A new modal needs to open when the user...
validations:
required: true
- type: textarea
id: figma
attributes:
label: Figma
description: Drop a Figma link if this enhancement impacts the UX.
placeholder: https://...
validations:
required: false
- type: textarea
id: assumptions
attributes:
label: Assumptions
description: What are the underlying assumptions guiding implementation?
placeholder: e.x. 1. users are not able to access this modal without...
validations:
required: false
8 changes: 4 additions & 4 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

version: 2
updates:
- package-ecosystem: "npm" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
interval: "weekly"
- package-ecosystem: 'npm' # See documentation for possible values
directory: '/' # Location of package manifests
schedule:
interval: 'weekly'
5 changes: 1 addition & 4 deletions .github/issue_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,14 @@ _Describe the Issue_
2. click button ...
3. ...


### Expected

_Describe what was expected_


### Actual

_Describe what actually occurred_


------
---

_Attach screen caps here_
14 changes: 9 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
### Describe your changes
### Describe your changes

_Describe the purpose + content of these changes_

### Link the related issue

_Closes #0000_

### Checklist before requesting a review
- [ ] Is this PR ready for merge? (Please convert to a draft PR otherwise)
- [ ] I have performed a self-review of my code.
- [ ] Did I request feedback from a team member prior to the merge?
- [ ] Does my code following the style guide at `docs/CODING-STYLE.md`?

- [ ] Is this PR ready for merge? (Please convert to a draft PR otherwise)
- [ ] I have performed a self-review of my code.
- [ ] Did I request feedback from a team member prior to the merge?
- [ ] Does my code following the style guide at `docs/CODING-STYLE.md`?

### Instructions for Reviewers

**Functionalities or workflows that should specifically be tested.**

1.
Expand Down
62 changes: 34 additions & 28 deletions docs/CODING-STYLE.md
Original file line number Diff line number Diff line change
@@ -1,42 +1,48 @@
#### Coding Style Checklist

Please follow these items as close to as possible for your PR. Please add a description or link a Git issue for context. Check off relevant items and remove them as not needed. These will help your reviewer find similar ground for starting their review from.
Please follow these items as close to as possible for your PR. Please add a description or link a Git issue for context. Check off relevant items and remove them as not needed. These will help your reviewer find similar ground for starting their review from.

#### Workflow Adherence
- [ ] Has an issue been created that this PR addresses?
- [ ] Has the PR been set to close relevant issues on GitHub?
- [ ] Did you pull code from branch `origin/develop` prior to submitting the PR?

- [ ] Has an issue been created that this PR addresses?
- [ ] Has the PR been set to close relevant issues on GitHub?
- [ ] Did you pull code from branch `origin/develop` prior to submitting the PR?

#### Code Quality
- [ ] Does the code stick to our formatting and code standards?
- [ ] Are magic numbers declared in centralized `const` variables?
- [ ] Did you run Prettier before creating the PR?
- [ ] Really? (Emily this means you)
- [ ] Do functions return a value through a single exit point?
- [ ] Does the app compile without errors or warnings?
- [ ] Has commented-out code been deleted or marked with a note to request preservation?
- [ ] Does error handling use `console.warn` or `console.error` for handled and unhandled exceptions, respectively? Does this logging reference the generating file?
- [ ] Have console commands been restricted with environmental variables (e.g. dev environment only) as appropriate?
- [ ] Are keyboard events tracked with `e.key` or `e.code` instead of `e.charCode` or `e.keyCode`?

- [ ] Does the code stick to our formatting and code standards?
- [ ] Are magic numbers declared in centralized `const` variables?
- [ ] Did you run Prettier before creating the PR?
- [ ] Really? (Emily this means you)
- [ ] Do functions return a value through a single exit point?
- [ ] Does the app compile without errors or warnings?
- [ ] Has commented-out code been deleted or marked with a note to request preservation?
- [ ] Does error handling use `console.warn` or `console.error` for handled and unhandled exceptions, respectively? Does this logging reference the generating file?
- [ ] Have console commands been restricted with environmental variables (e.g. dev environment only) as appropriate?
- [ ] Are keyboard events tracked with `e.key` or `e.code` instead of `e.charCode` or `e.keyCode`?

#### TypeScript
- [ ] Are all functions given a typed return?
- [ ] Are overloads used where a function has multiple possible return types?

- [ ] Are all functions given a typed return?
- [ ] Are overloads used where a function has multiple possible return types?

#### JSX Files
- [ ] Do JSX files contain one and only one React functional component?
- [ ] Are props checked against an interface defined locally and declared as `propsIF`?
- [ ] Is each JSX file located in its own sub-directory?
- [ ] Do JSX files map 1:1 with related files? (eg CSS modules, test files, etc)
- [ ] Are React functional components declared as a default export?

- [ ] Do JSX files contain one and only one React functional component?
- [ ] Are props checked against an interface defined locally and declared as `propsIF`?
- [ ] Is each JSX file located in its own sub-directory?
- [ ] Do JSX files map 1:1 with related files? (eg CSS modules, test files, etc)
- [ ] Are React functional components declared as a default export?

#### Data Management
- [ ] Are data fetches described with an interface for the incoming data shape and an extended interface for the internal post-decorating specification?
- [ ] Are data and relevant methods packaged together in objects?
- [ ] Are objects instantiated through a centralized process when made in parallel? (factory function, class constructor, etc)
- [ ] Are classes checked against an interface via the `implements` keyword?
- [ ] Is newly-written logic necessary due to a lack of centralized logic?
- [ ] Is every top-level code block explained with a comment?

- [ ] Are data fetches described with an interface for the incoming data shape and an extended interface for the internal post-decorating specification?
- [ ] Are data and relevant methods packaged together in objects?
- [ ] Are objects instantiated through a centralized process when made in parallel? (factory function, class constructor, etc)
- [ ] Are classes checked against an interface via the `implements` keyword?
- [ ] Is newly-written logic necessary due to a lack of centralized logic?
- [ ] Is every top-level code block explained with a comment?

#### Testing
- [ ] Are unit tests used where possible? In most cases, tests should be present for APIs, interfaces with data access, transformation, backend elements and models, with the Arrange/Act/Assert pattern and documentation.

- [ ] Are unit tests used where possible? In most cases, tests should be present for APIs, interfaces with data access, transformation, backend elements and models, with the Arrange/Act/Assert pattern and documentation.
20 changes: 7 additions & 13 deletions src/App/App.css
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ body {
/* padding: 0 1rem; */
}



h3:focus-visible,
h2:focus-visible,
h1:focus-visible,
Expand Down Expand Up @@ -347,26 +345,22 @@ input[type='number'] {

.custom_scroll_ambient::-webkit-scrollbar {
width: 5px !important;
}


/* Handle */
.custom_scroll_ambient::-webkit-scrollbar-thumb {
background:
linear-gradient(
}

/* Handle */
.custom_scroll_ambient::-webkit-scrollbar-thumb {
background: linear-gradient(
0deg,
var(--accent1) 0%,
var(--accent5) 49.48%,
var(--accent1) 100%
) !important;
}
}

/* .custom_scroll_ambient{
/* .custom_scroll_ambient{
scrollbar-width: thin;
scrollbar-color: transparent;
} */


}

@media only screen and (min-width: 1280px) {
Expand Down
8 changes: 4 additions & 4 deletions src/App/components/GlobalPopup/GlobalPopup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ function GlobalPopup() {
placement === 'left'
? styles.popup_left
: placement === 'center'
? styles.popup_center
: placement === 'right'
? styles.popup_right
: styles.popup_right;
? styles.popup_center
: placement === 'right'
? styles.popup_right
: styles.popup_right;

return (
<div
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.container{
.container {
height: auto;
border: none;
overflow: hidden;
Expand All @@ -8,8 +8,7 @@
}

@media only screen and (min-width: 768px) {
.container{

.container {
height: 510px;
border-radius: var(--border-radius);
box-shadow: 4px 4px 12px rgba(0, 0, 0, 0.25);
Expand All @@ -19,5 +18,4 @@
right: 5px;
border: 1px solid var(--accent1);
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export const ExchangeBalanceDropdown = () => {
const [fullLayoutActive, setFullLayoutActive] = useState<boolean>(false);
const [tokenModalOpen, setTokenModalOpen] = useState(false);
const escapePressed = useKeyPress('Escape');


useEffect(() => {
if (fullLayoutActive && !tokenModalOpen && escapePressed) {
Expand Down
Loading

0 comments on commit 86c8c8a

Please sign in to comment.