-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4367 from CrocSwap/apply-prettier-to-all-files-no…
…v-20 apply prettier to all files
- Loading branch information
Showing
244 changed files
with
6,083 additions
and
4,487 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
name: Technical Debt | ||
description: File technical debt | ||
title: "[Tech Debt]: " | ||
labels: ["technical debt"] | ||
title: '[Tech Debt]: ' | ||
labels: ['technical debt'] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: "Thanks for taking the time to document deferred engineering work!" | ||
- type: textarea | ||
id: work-required | ||
attributes: | ||
label: What is needed? | ||
description: Tell / show what work is being deferred, (link back to the codebase with TODO if possible). | ||
placeholder: What work is being deferred? (NOTE solutioning is not needed here) | ||
validations: | ||
required: true | ||
- type: markdown | ||
attributes: | ||
value: 'Thanks for taking the time to document deferred engineering work!' | ||
- type: textarea | ||
id: work-required | ||
attributes: | ||
label: What is needed? | ||
description: Tell / show what work is being deferred, (link back to the codebase with TODO if possible). | ||
placeholder: What work is being deferred? (NOTE solutioning is not needed here) | ||
validations: | ||
required: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,32 @@ | ||
name: Enhancement | ||
description: File an Enhancement | ||
title: "[Enhancement]: " | ||
labels: ["enhancement"] | ||
title: '[Enhancement]: ' | ||
labels: ['enhancement'] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: "Thanks for taking the time to fill out this ticket!" | ||
- type: textarea | ||
id: requirements | ||
attributes: | ||
label: Requirements | ||
description: Tell / show the feature requirements, screenshots are helpful! | ||
placeholder: e.x. A new modal needs to open when the user... | ||
validations: | ||
required: true | ||
- type: textarea | ||
id: figma | ||
attributes: | ||
label: Figma | ||
description: Drop a Figma link if this enhancement impacts the UX. | ||
placeholder: https://... | ||
validations: | ||
required: false | ||
- type: textarea | ||
id: assumptions | ||
attributes: | ||
label: Assumptions | ||
description: What are the underlying assumptions guiding implementation? | ||
placeholder: e.x. 1. users are not able to access this modal without... | ||
validations: | ||
required: false | ||
- type: markdown | ||
attributes: | ||
value: 'Thanks for taking the time to fill out this ticket!' | ||
- type: textarea | ||
id: requirements | ||
attributes: | ||
label: Requirements | ||
description: Tell / show the feature requirements, screenshots are helpful! | ||
placeholder: e.x. A new modal needs to open when the user... | ||
validations: | ||
required: true | ||
- type: textarea | ||
id: figma | ||
attributes: | ||
label: Figma | ||
description: Drop a Figma link if this enhancement impacts the UX. | ||
placeholder: https://... | ||
validations: | ||
required: false | ||
- type: textarea | ||
id: assumptions | ||
attributes: | ||
label: Assumptions | ||
description: What are the underlying assumptions guiding implementation? | ||
placeholder: e.x. 1. users are not able to access this modal without... | ||
validations: | ||
required: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,48 @@ | ||
#### Coding Style Checklist | ||
|
||
Please follow these items as close to as possible for your PR. Please add a description or link a Git issue for context. Check off relevant items and remove them as not needed. These will help your reviewer find similar ground for starting their review from. | ||
Please follow these items as close to as possible for your PR. Please add a description or link a Git issue for context. Check off relevant items and remove them as not needed. These will help your reviewer find similar ground for starting their review from. | ||
|
||
#### Workflow Adherence | ||
- [ ] Has an issue been created that this PR addresses? | ||
- [ ] Has the PR been set to close relevant issues on GitHub? | ||
- [ ] Did you pull code from branch `origin/develop` prior to submitting the PR? | ||
|
||
- [ ] Has an issue been created that this PR addresses? | ||
- [ ] Has the PR been set to close relevant issues on GitHub? | ||
- [ ] Did you pull code from branch `origin/develop` prior to submitting the PR? | ||
|
||
#### Code Quality | ||
- [ ] Does the code stick to our formatting and code standards? | ||
- [ ] Are magic numbers declared in centralized `const` variables? | ||
- [ ] Did you run Prettier before creating the PR? | ||
- [ ] Really? (Emily this means you) | ||
- [ ] Do functions return a value through a single exit point? | ||
- [ ] Does the app compile without errors or warnings? | ||
- [ ] Has commented-out code been deleted or marked with a note to request preservation? | ||
- [ ] Does error handling use `console.warn` or `console.error` for handled and unhandled exceptions, respectively? Does this logging reference the generating file? | ||
- [ ] Have console commands been restricted with environmental variables (e.g. dev environment only) as appropriate? | ||
- [ ] Are keyboard events tracked with `e.key` or `e.code` instead of `e.charCode` or `e.keyCode`? | ||
|
||
- [ ] Does the code stick to our formatting and code standards? | ||
- [ ] Are magic numbers declared in centralized `const` variables? | ||
- [ ] Did you run Prettier before creating the PR? | ||
- [ ] Really? (Emily this means you) | ||
- [ ] Do functions return a value through a single exit point? | ||
- [ ] Does the app compile without errors or warnings? | ||
- [ ] Has commented-out code been deleted or marked with a note to request preservation? | ||
- [ ] Does error handling use `console.warn` or `console.error` for handled and unhandled exceptions, respectively? Does this logging reference the generating file? | ||
- [ ] Have console commands been restricted with environmental variables (e.g. dev environment only) as appropriate? | ||
- [ ] Are keyboard events tracked with `e.key` or `e.code` instead of `e.charCode` or `e.keyCode`? | ||
|
||
#### TypeScript | ||
- [ ] Are all functions given a typed return? | ||
- [ ] Are overloads used where a function has multiple possible return types? | ||
|
||
- [ ] Are all functions given a typed return? | ||
- [ ] Are overloads used where a function has multiple possible return types? | ||
|
||
#### JSX Files | ||
- [ ] Do JSX files contain one and only one React functional component? | ||
- [ ] Are props checked against an interface defined locally and declared as `propsIF`? | ||
- [ ] Is each JSX file located in its own sub-directory? | ||
- [ ] Do JSX files map 1:1 with related files? (eg CSS modules, test files, etc) | ||
- [ ] Are React functional components declared as a default export? | ||
|
||
- [ ] Do JSX files contain one and only one React functional component? | ||
- [ ] Are props checked against an interface defined locally and declared as `propsIF`? | ||
- [ ] Is each JSX file located in its own sub-directory? | ||
- [ ] Do JSX files map 1:1 with related files? (eg CSS modules, test files, etc) | ||
- [ ] Are React functional components declared as a default export? | ||
|
||
#### Data Management | ||
- [ ] Are data fetches described with an interface for the incoming data shape and an extended interface for the internal post-decorating specification? | ||
- [ ] Are data and relevant methods packaged together in objects? | ||
- [ ] Are objects instantiated through a centralized process when made in parallel? (factory function, class constructor, etc) | ||
- [ ] Are classes checked against an interface via the `implements` keyword? | ||
- [ ] Is newly-written logic necessary due to a lack of centralized logic? | ||
- [ ] Is every top-level code block explained with a comment? | ||
|
||
- [ ] Are data fetches described with an interface for the incoming data shape and an extended interface for the internal post-decorating specification? | ||
- [ ] Are data and relevant methods packaged together in objects? | ||
- [ ] Are objects instantiated through a centralized process when made in parallel? (factory function, class constructor, etc) | ||
- [ ] Are classes checked against an interface via the `implements` keyword? | ||
- [ ] Is newly-written logic necessary due to a lack of centralized logic? | ||
- [ ] Is every top-level code block explained with a comment? | ||
|
||
#### Testing | ||
- [ ] Are unit tests used where possible? In most cases, tests should be present for APIs, interfaces with data access, transformation, backend elements and models, with the Arrange/Act/Assert pattern and documentation. | ||
|
||
- [ ] Are unit tests used where possible? In most cases, tests should be present for APIs, interfaces with data access, transformation, backend elements and models, with the Arrange/Act/Assert pattern and documentation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.