[Draft] Move memory transpose logic to the Fortran client #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transpose capabilties will be embedded in the Fortran client and the C++/C clients will only be responsible for C-style memory layouts.
mellis13
added
type: refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the memory transpose logic from the C++ client to the Fortran client. For large messages originating in the Fortran client, it was demonstrated that intrinsic Fortran methods are much more efficient at doing the transform. Going forward, the C++ client will only be responsible for c-style contiguous and nested memory layouts. This greatly simplifies the internal logic of the clients.