Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added workaround for the conflict in --hostname #139

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Added workaround for the conflict in --hostname #139

merged 2 commits into from
Apr 18, 2024

Conversation

shunr-hpe
Copy link
Contributor

Summary and Scope

Added a workaround so that the global --hostname value (from the config file) does not get used in in cray hsm redfishEndpoints update and cray hsm redfishEndpoints create. These calls also have a --hostname option.

This PR also updates the hsm swagger file.

Issue Type

  • Bugfix Pull Request

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (if yes, please include results or a description of the test)
  • I tested this on a vshasta system (if yes, please include results or a description of the test)

Idempotency

Risks and Mitigations

@shunr-hpe
Updated hsm swagger files
ea95a8a
@shunr-hpe
Added workaround for setting hostname in hsm
7d3f04d 
Changed redfishEndpoints update and redfishEndpoints create to not use
the hostname if it starts with http: or https:
@shunr-hpe shunr-hpe requested review from a team as code owners April 17, 2024 01:58
@shunr-hpe shunr-hpe merged commit 86936cd into master Apr 18, 2024
6 checks passed
@shunr-hpe shunr-hpe deleted the hsm-patch branch April 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwlv jwlv jwlv approved these changes

@mbuchmann-hpe mbuchmann-hpe mbuchmann-hpe approved these changes

@rustydb rustydb Awaiting requested review from rustydb rustydb is a code owner automatically assigned from Cray-HPE/cloud

@erl-hpe erl-hpe Awaiting requested review from erl-hpe erl-hpe is a code owner automatically assigned from Cray-HPE/cloud

@spillerc-hpe spillerc-hpe Awaiting requested review from spillerc-hpe spillerc-hpe is a code owner automatically assigned from Cray-HPE/cloud

@jsollom-hpe jsollom-hpe Awaiting requested review from jsollom-hpe jsollom-hpe is a code owner automatically assigned from Cray-HPE/hardware-management

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shunr-hpe @mbuchmann-hpe @jwlv