Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMPET-7207: Add new permissions for the tapms operator role in vault. #18

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

ndavidson-hpe
Copy link
Contributor

Summary and Scope

This only adds more permissions to the tapms operator to allow it to create policy and roles for tenant specific transit engines. The only change in how the auth policy works is allowing tapms-operator to create and delete specific policy only for tenant specific endpoints. Vault has no more openings only allowing new policy to be made.

Issues and Related PRs

Testing

Tested on:

  • Beau

Test description:

The test was to put the new policy up and see if the tapms-operator has correct permissions.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?y
  • Were continuous integration tests run? If not, why?y
  • Was upgrade tested? If not, why?y
  • Was downgrade tested? If not, why?y
  • Were new tests (or test issues/Jiras) created for this change?y

Risks and Mitigations

Low risk as it only opens endpoints that the tapms-operator can access.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@ndavidson-hpe ndavidson-hpe requested a review from a team as a code owner October 16, 2024 21:12
Copy link

@ethanholen-hpe ethanholen-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ndavidson-hpe ndavidson-hpe merged commit d5cf5ab into master Oct 31, 2024
7 of 10 checks passed
@ndavidson-hpe ndavidson-hpe deleted the CASMPET-7207 branch October 31, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants